fix: Action Plan matrix item type render bugs (M2-8348) #560
+107
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8348
Simplified and fixed logic for generating response text for matrix item types (Single Selection per Row, Multiple Selection per Row). Aligned behaviour with Figma (see 4 examples shown in this row). Specifically:
columnLabel rowLabel
vs.rowLabel columnLabel
(and whether to display as bullets or sentences – although that aspect wasn't touched in this PR).📸 Screenshots
CleanShot.2024-12-09.at.15.50.00.mp4
🪤 Peer Testing
Setup:
Steps:
Expected outcome: Rows for which there are no answers do not display "(Question skipped)"
Expected outcome: Responses are rendered in the order of walking through the grid from left to right and top to bottom, as if reading a paragraph of text (per Figma spec).
Expected outcome: Each response is rendered as "(Question skipped)" in the Action Plan.
Expected outcome: Responses are still rendered in the order of walking through the grid from left to right and top to bottom, as if reading a paragraph of text (per Figma spec), with the only change being whether the answers are rendered as a sentence vs. a bullet list, or the order in which each response has its row/column label displayed.